Open naanmohammed opened 1 year ago
Hi @naanmohammed
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
You have submitted a project, that I cannot access because it's private:
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready π
Cheers and Happy coding!πππ
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
Invalid Code Review Request does not count into the code reviews limit.
Hi @naanmohammed,
Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!
According to the project requirements:
I can see none of the tasks have a description:
Therefore:
That way, we will meet this particular requirement πͺ
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!πππ
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Hi @naanmohammed,
Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! π
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!πππ
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Thank you very much @Meltrust
Link to Project : https://github.com/users/naanmohammed/projects/2
There are two people in this team : @naanmohammed @Cisco-the-wayword