naari3 / offers-hud

OffersHUD is a client-side mod which display a list of villager's trading offers as a HUD, without a right-click.
https://www.curseforge.com/minecraft/mc-mods/offershud
MIT License
9 stars 1 forks source link

Prevents opening goblin traders trading interface when installed #51

Open Luky05005 opened 1 month ago

Luky05005 commented 1 month ago

When running this mod on fabric (1.20.1) with goblin traders mod I'm unable to open the goblins trading inventory, both on servers and in singleplayer.

Disabling mod in config doesn't help.

image

Mods: image

I'd really appreciate if you could fix this issue, because I think that this is a great mod and I would love to use it, but I'm playing on a server and not being able to use the goblins basically makes the mod unusable.

naari3 commented 1 month ago

I dont know about this mod, so I am digging GoblinTraders repo at first. What we know so far, GoblinTraderEntity implements Merchant. and, This mod causes interaction to target entity and I think this might be the cause this issue.

naari3 commented 1 month ago

It seems necessary to check how to open the window. At the very least, I thought that the implementation for MerchantEntity would be sufficient, so this seems a bit difficult.

Luky05005 commented 1 month ago

I don't know anything about java, but thanks for looking into it. I understand if it might be impossible, but i appreciate that you responded, because most likely I'm the only person, who has encountered this issue. But maybe in the future, if you manage to fix this, it'll save somebody a headache.