nabaztag2018 / pynab

Nabaztag en Python pour RaspberryPi
GNU General Public License v3.0
161 stars 54 forks source link

Cleanup macOS leftovers from Pynab image #146

Closed f-laurens closed 3 years ago

f-laurens commented 4 years ago

it would be nice to add a phase at the end of the Pynab create-image script to do some clean up of macOS leftovers from the image:

Also make sure that all files in /home/pibelong to pi:pi(some of them belong to root:root)

Also maybe remove /usr/bin/qemu-arm-static*x86 binaries from image.

pguyot commented 4 years ago

Confused about the issue. Are you talking about released images or images you build yourself on your mac?

f-laurens commented 4 years ago

This is about released images. I noticed this initially on the 0.7.4 image (but forgot about it...), and noticed it again on the 0.8.1 image. The ._*files are mainly in the /opt/kaldi directory tree. The files belonging to root in /home/pi are artefacts from builds of the drivers.

mehdichaouch commented 3 years ago

Maybe integrate this script remove_macintrash.sh in your CI/CD ?

pguyot commented 3 years ago

Also maybe remove /usr/bin/qemu-arm-static*x86 binaries from image.

Fixed in #193

The ._*files are mainly in the /opt/kaldi directory tree.

This may come from kaldi binaries which could have been packaged on my Mac.

The files belonging to root in /home/pi are artefacts from builds of the drivers.

Umm. Indeed drivers are built and installed with sudo.

f-laurens commented 3 years ago

@pguyot: As of the current (0.9.0 pre-release) image build process , there are still some macOS leftovers in the images built on GitHub, which apparently come from the Kaldi build: