search

nabaztag2018 / pynab

Nabaztag en Python pour RaspberryPi
GNU General Public License v3.0
158 stars 54 forks source link

Cleanup nabradio & nabwebook #443

Closed f-laurens closed 1 year ago

f-laurens commented 1 year ago

Fix and localize application names. Cleanup logging and exception handling.

lgtm-com[bot] commented 1 year ago

This pull request introduces 6 alerts when merging dc65080abe9787d3adb349970c1d26934c7f0044 into e46ed3c06760591ad1656d3d6dee6b8286c1f19a - view on LGTM.com

new alerts:

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. It looks like GitHub code scanning with CodeQL is already set up for this repo, so no further action is needed :rocket:. For more information, please check out our post on the GitHub blog.

f-laurens commented 1 year ago

Another slight issue (not handled here) is with the module/service names, which should rather have been nabradiod and nabwebhookd, for consistency with existing services. But this would be tricky to change now, since users may have already upgraded to/installed v1.0.2.