search

nabeelamjad / poke-api

Poke API - A Ruby API gem for Pokémon GO.
MIT License
82 stars 22 forks source link

Add S2 Geometry classes to Poke-API #28

Closed nabeelamjad closed 8 years ago

nabeelamjad commented 8 years ago

If anyone can have a double check over this before I merge it in then that'd be greatly appreciated!

This fixes #2

xssc commented 8 years ago

Not a lot of ruby devs on the discord so throwing it out there that I can check this over tomorrow (btw Id consider making this its own gem, even thought it not full s2(neither is s2phere) but not required).

nabeelamjad commented 8 years ago

Yeah could do that I suppose, though it will lack a lot of functionality in general for anyone wanting to use it outside the scope of Pokemon GO (which is why I added it in the the gem itself).

xssc commented 8 years ago

Well maybe if theres a wider demand people would be more likely to contribute outside of pogo. Just a thought. Call it an unfinished port or something

nabeelamjad commented 8 years ago

Sounds good, I'll create its own repository tomorrow.