nabeelio / phpvms

virtual airline management
http://www.phpvms.net
Other
169 stars 135 forks source link

Email Layout Blade Change Causing Weird Behavior #1775

Open vAAGroup opened 4 months ago

vAAGroup commented 4 months ago

Describe the bug After changing the email template (custom theme folder/vendor/mail/html/layout.blade.php) we are experiencing weird things. The user gets the email asking them to verify their email and it correctly shows the new layout.blade.php file in the email. They do not receive the "Your registration is pending" email even after verifying their email. The admins also do not get alerted via email to the new registration pending.

After you log in and change the pending user to "active" status from "pending" it then sends off the "Your registration is pending" and "Welcome to ___!" emails to the user as well as the "A new user registered" to the admin but all of those show the default layout.blade.php file and not the customized one. Checking the logs there are no errors being shown.

Version 7.0.0-dev+240124.225c43

To Reproduce Steps to reproduce the behavior:

  1. Go to 'custom theme folder/vendor/mail/html/layout.blade.php'
  2. Make any changes to the table views.
  3. Attempt to register a new user.
  4. See the changes and how the emails are being sent.

Expected behavior The emails should always reflect the changes made to the theme's layout.blade.php and changing them should not cause emails to not send at the correct time.

Screenshots If applicable, add screenshots to help explain your problem.

Custom Blade Screenshot 2024-02-15 165157

What it reverts to Screenshot 2024-02-15 165210

vAAGroup commented 4 months ago

Seems related to #1776

vAAGroup commented 3 months ago

After a discussion in discord it seems that this is not related to #1776. Initial email asking the user to verify the email address comes through with the updated theme for the email template but all subsequent emails are reverted to the default.

arthurpar06 commented 3 months ago

Hi,

Does this bug still occur with the latest dev?

Theoretically, when a user registers, they should receive an email asking them to verify their email address. Once this is done, the user should receive the "Your registration is pending" email, and the admins should receive the "New user registered" email.

vAAGroup commented 3 months ago

Hi,

Does this bug still occur with the latest dev?

Theoretically, when a user registers, they should receive an email asking them to verify their email address. Once this is done, the user should receive the "Your registration is pending" email, and the admins should receive the "New user registered" email.

Hey Arthur, Yes this bug still occurs. It now seems to send on schedule but the theme does not match. On the email asking the user to verify the email we show the updated custom theme, they verify the email, and then the subsequent emails that are sent to both the admin as well as the user (Your registration is pending, new user registered, your account is ready to use) are all in the default theme. We have not tried changing the text for the emails yet as we are just trying to make sure we can get the theme to work as needed. Thanks!

AussieVirtual commented 4 days ago

I concur this occurring with us to.