cURL error 3 during update

web541 commented 4 years ago

Describe the bug As reference on the forum thread here the /update is throwing a cURL 3 error for a number of users. I've done some investigation on it which I provide below.

Version 7.0.0-beta.3 7.0.0-beta.4 dev branch

To Reproduce Steps to reproduce the behavior:

Go to Admin Panel -> Maintenance -> Update or /update route
Click "Update"

Error thrown

GuzzleHttp\Exception\RequestException
cURL error 3: (see http://curl.haxx.se/libcurl/c/libcurl-errors.html)

Expected behavior Update of phpVMS installation (as far as I'm aware)

Bit of investigation On all versions tested above the same error is thrown. On beta.4 the update fails to recognise that there is no update available as it should already be on the latest version. On dev, not sure if it's supposed to do the same as it's completely different and I assume the update is pulling off the master branch? The updater doesn't seem to like this line (UpdateModule -> UpdateController.php line 134). So I did some dumping and doing something like this:

        $version = $this->kvpRepo->get('latest_version_tag');
        $release = $this->updateManager->source('github')->getVersionAvailable();
        dd($release);
        $this->updateManager->source('github')->update($version);

Should have brought back "7.0.0-beta.4" or similar as the most up-to-date version. Instead, it throws the cURL error. Similarly, doing this:

        $version = $this->kvpRepo->get('latest_version_tag');
        $release = $this->updateManager->source('github')->getVersionInstalled();
        dd($release);
        $this->updateManager->source('github')->update($version);

Should have brought back the version currently installed, but instead it returns null. If I adjust the config/self-update.php 'version_installed' key to the current version (as seen in php artisan phpvms:version and run the code again, this time it gives the current version but then sets this value to '' again in the config file. Upon looking into the cURL error 3, I believe it's a URL issue somewhere. So looking into the vendor's self-update GithubTagTest.php file and dumping this line it gives me this "/repos/nabeelio/phpvms/tags".

The only way I could get rid of the cURL error was to manually specify this: $url = "https://api.github.com/repos/nabeelio/phpvms/releases"; before this line in the vendor's file (which I will revert). And update the UpdateController to this:

        $version = $this->kvpRepo->get('latest_version_tag');
        $release = $this->updateManager->source('github')->getVersionAvailable();
        $this->updateManager->source('github')->update($release);

After this, the installer runs fine, no errors and the update successfully dumps to storage/app/*version. The update fails to recognise after that it has updated (still says "update available" in the admin panel" and at this point, the config/self-update.php 'version_installed' reverts to an empty string ''.

As a sidenote, if I dump $version from here:

        $version = $this->kvpRepo->get('latest_version_tag');
        $this->updateManager->source('github')->update($version);

it returns null. And I think there's supposed to be a storage/app/kvp.json file (could be wrong) but it doesn't look like there is one there. The /storage directory is set to 777 to ensure that it's not a permissions issue.

Sorry if this is a bit overkill (hopefully a simple fix) but I thought I'd do some digging. Not sure if the installer has worked prior to beta 3 or if it's a change made to beta 4.

Additional context Attached is the log file laravel-2020-05-20.log