search

nabijaczleweli / cargo-update

A cargo subcommand for checking and applying updates to installed executables
MIT License
1.22k stars 42 forks source link

don't abort if a package fails to build #102

Closed matthiaskrgr closed 5 years ago

matthiaskrgr commented 5 years ago

It would be great if cargo-update continued execution if a package failed to build. Currently if a package fails to build it aborts but there may be other packages that still need update.

I would suggest continuing execution and remembering all packages that failed to build and printing a small summary of the update/build failures at the end.

nabijaczleweli commented 5 years ago

Ah, that's a smart thing to do, indeed, let's see if I can smash it out

nabijaczleweli commented 5 years ago

Wait, it seems we already do this? Can you provide a case when this fails?

Correctly-working case SS

matthiaskrgr commented 5 years ago

Hmm, I can't remember exactly right now what happened... I usually run cargo install-update -ag though, maybe failed upgrades of crates.io crates prevented git repo packages from being updated?

nabijaczleweli commented 5 years ago

That would be the only case I can think of, because fail aggregation was introduced in e672fcf757a920a7667a5c8b3ed44cd750098416, and therefore released in v0.6.0 on Wed Nov 30 23:51:14 2016 +0100, so this'd either've to be a cornercase that's slipped your dutiful fingers for two years :Р

I'll see about doing the git update round after repo updates fail

nabijaczleweli commented 5 years ago

See associated commit, and I'll release if it works well for ye!

nabijaczleweli commented 5 years ago

Released in v1.8.0