search

nabijaczleweli / cargo-update

A cargo subcommand for checking and applying updates to installed executables
MIT License
1.22k stars 42 forks source link

Doesn't respect system proxy #106

Closed ThinkChaos closed 5 years ago

ThinkChaos commented 5 years ago

At work I need to use the office proxy otherwise I can't connect to the internet over HTTP(S). cargo-update doesn't detect the system proxy so it fails when trying to update the registry.

Could you add support for using system configured proxies? Usually proxies are configured through HTTP_PROXY and HTTPS_PROXY environment variables. For cargo specifically, it's http.proxy and https.proxy in ~/.cargo/config.

nabijaczleweli commented 5 years ago

I'm currently away, but I'll see about stealing Cargo's behaviour when I get back on Monday. Thanks for the report!

nabijaczleweli commented 5 years ago

Please check if the current master works for you, if you'd?

nabijaczleweli commented 5 years ago

Released in v1.8.0, but it'd be nice to know if the behaviour is as expected on your system, too

ThinkChaos commented 5 years ago

Sorry I forgot to respond the first time.

It works great on my system!

nabijaczleweli commented 5 years ago

Kickass!