search

nabijaczleweli / cargo-update

A cargo subcommand for checking and applying updates to installed executables
MIT License
1.25k stars 41 forks source link

Support private registries #167

Closed Logarithmus closed 3 years ago

Logarithmus commented 3 years ago

Support private registries

See https://github.com/nabijaczleweli/cargo-update/issues/164#issuecomment-965558321

Closes #164

nabijaczleweli commented 3 years ago

Maybe the first commit, sure, but drop the one where you rewrite the entire repository for no reason lol, and the second one that breaks 1.35.0 builds, for seemingly also little reason?

Logarithmus commented 3 years ago

@nabijaczleweli why do you insist on using 2.5 years old version of Rust? Just remove this job from CI. I "rewrite the entire repository" for a reason, and the reason is to make your rustfmt.toml work and to format source code according to your rustfmt.toml, since you didn't update it in 3 years, and some options have changed since then. If you refuse to use cargo fmt, then better remove rustfmt.toml from the repo to avoid confusion.

nabijaczleweli commented 3 years ago

(a) MSRV, I don't see a reason to break that interface, and (b) excuse you, I do use rustfmt and this is the config for it. If your version doesn't like it, then the answer is to leave it unformatted, not rewrite the repository, destroying any and all hope of git blame being useful again.

Logarithmus commented 3 years ago

@nabijaczleweli I've removed clippy & rustfmt commits, as you wish. But still don't get why would anyone want to use 2.5 years old Rust. As you can see, there are no public crates using your project as a dependency: https://lib.rs/crates/cargo-update/rev Also you can just release 9.0.0 & break any interfaces, those who use 8.0.0 won't suffer any breakage at all.

P.S. What does MSRV mean?

nabijaczleweli commented 3 years ago

Looks good!

nabijaczleweli commented 2 years ago

Released in v8.1.0!