nabijaczleweli / cargo-update

A cargo subcommand for checking and applying updates to installed executables
MIT License
1.22k stars 42 forks source link

Support for cargo `install-update -a --locked` #273

Closed luccahuguet closed 1 month ago

luccahuguet commented 1 month ago

I am aware of https://github.com/nabijaczleweli/cargo-update/issues/152 and https://github.com/nabijaczleweli/cargo-update/issues/191

but i think it would be much more user friendly allowing for direct usage of the --locked option

if implementing this is completely out of the table, we can close this issue, no problems.

NobodyXu commented 1 month ago

P.S. cargo-binstall does support --locked, so there shouldn't be any issue from cargo-binstall

luccahuguet commented 1 month ago

P.S. cargo-binstall does support --locked, so there shouldn't be any issue from cargo-binstall

thank you Jiahao

I'll consider using binstall directly then

luccahuguet commented 1 month ago

this why im using cargo-update btw

https://github.com/luccahuguet/rustifier

nabijaczleweli commented 1 month ago

Given that you're bypassing actual cargo-update configuration and you just want to add Some String to cargo argv, the manual prescribes CARGO_INSTALL_OPTS=--locked for this.

nabijaczleweli commented 1 month ago

Admittedly, this disables the cargo-binstall upcall, but then so does any config. But clearly this is something users keep wanting for.. some reason.

nabijaczleweli commented 1 month ago

Can you try the current master branch (at least addb658d22ef60c9edc22bb8a3dc9531f0df048c)?

luccahuguet commented 1 month ago

Admittedly, this disables the cargo-binstall upcall, but then so does any config. But clearly this is something users keep wanting for.. some reason.

Its stronger than me

I admit it, it’s not rational

luccahuguet commented 1 month ago

Can you try the current master branch (at least addb658d22ef60c9edc22bb8a3dc9531f0df048c)?

This looks beautiful https://github.com/nabijaczleweli/cargo-update/commit/addb658d22ef60c9edc22bb8a3dc9531f0df048c

You can check it with gitui (it breaks without --locked)

I will personally wait for the new release tho...

Thank you for listening to your users!

nabijaczleweli commented 1 month ago

Released in v14.1.0