search

nabijaczleweli / cargo-update

A cargo subcommand for checking and applying updates to installed executables
MIT License
1.22k stars 42 forks source link

Build fails for macOS 10.13 #52

Closed oceanlewis closed 6 years ago

oceanlewis commented 7 years ago

Maybe I'm just not setting an environment variable that I should be - but building fails with error: failed to run custom build command for 'libgit2-sys v0.6.15'. I should probably file this with git2-rs, but I can't really verify that git2-rs breaks because I don't use it.

Also note that I have the Homebrew packages for openssl and libssh2 installed.

If this is a path configuration thing, it also might be nice to have that as part of the readme.

Attaching a log to be somewhat helpful log.txt

Thanks

nabijaczleweli commented 7 years ago

Try setting CMAKE_PREFIX_PATH to where libssh2 is installed (or up, or up from that, you get the gist)?

If that doesn't work, this is probably a problem with git2-rs (and opening an issue there should work, I think)?

oceanlewis commented 7 years ago

No dice. I'll file an issue and see where it goes. Thanks

nabijaczleweli commented 7 years ago

Cool, I love build system errors :v

oceanlewis commented 7 years ago

I've filed a an issue with git2-rs here for reference: https://github.com/alexcrichton/git2-rs/issues/257

mati865 commented 6 years ago

libgit2-sys 0.6.16 containing fix has been released over month ago. Probably fine to close.

nabijaczleweli commented 6 years ago

If you say so!