nabijaczleweli / cargo-update

A cargo subcommand for checking and applying updates to installed executables
MIT License
1.22k stars 42 forks source link

Use rawgit non-forever-cached URLs #91

Closed pzmarzly closed 5 years ago

pzmarzly commented 6 years ago

In the repo there are links to rawgit, e.g. https://cdn.rawgit.com/nabijaczleweli/cargo-update/doc/cargo_update/index.html (added 2 years ago).

The problem is that according to rawgit.com FAQ, files linked by branch get cached permanently, so if you intend to change the content, you should instead link by tag or by commit ID:

So, instead of a URL like https://cdn.rawgit.com/user/repo/branch/file, use a URL like https://cdn.rawgit.com/user/repo/tag/file or https://cdn.rawgit.com/user/repo/commit/file.

This would also make documentation updates atomic (there won't be a situation where CDN serves some files from new version and some from old).

nabijaczleweli commented 6 years ago

This is a good suggestion but I'm on the fence about the tradeoffs. I'll think about it, and thank you!

nabijaczleweli commented 5 years ago

Globally switched to githack, and IME the cache doesn't live too too long there. Thanks again for the suggestion, though