search

nabijaczleweli / rust-embed-resource

A Cargo build script library to handle compilation and inclusion of Windows resources, in the most resilient fashion imaginable
MIT License
173 stars 29 forks source link

Change SDK search implementation order #38

Closed thenextman closed 2 years ago

thenextman commented 2 years ago

On GitHub Windows runners, multiple SDK versions are installed (and none are in the PATH). Although VS is installed, no build environment is set up.

find_windows_kits_tool seemingly locates RC.exe in {KITSROOT10}/bin{arch} just fine, but in general, isn't it better to run find_windows_10_kits_tool first, which would also ensure that INCLUDE is properly set?

Otherwise, in GitHub workflows, we need to manually configured INCLUDE or encounter not found headers (e.g. Windows.h or, in my case, winresc.h)

This PR applies that change

nabijaczleweli commented 2 years ago

fair enough

nabijaczleweli commented 2 years ago

Released in v1.6.5