search

nabijaczleweli / rust-embed-resource

A Cargo build script library to handle compilation and inclusion of Windows resources, in the most resilient fashion imaginable
MIT License
166 stars 29 forks source link

Update dependencies (winreg, toml) #55

Closed poliorcetics closed 1 year ago

poliorcetics commented 1 year ago

I haven't seen an MSRV so I think updating is okay, don't hesitate to tell me if there is one, I can check.

poliorcetics commented 1 year ago

Nothing from those deps is in the public API I think, so a minor release should be enough ?

nabijaczleweli commented 1 year ago

The MSRV was soft 1.35.0 before v1.3.3, then hard 1.35.0 before v1.8.0, then soft 1.36.0 before v2.0.0, it's now soft 1.45.0, cf. those tags.

I've given up on exceedingly hard MSRVs here; well, unless it's something insanely fresh like 1.65, but if it passes AppVeyor's 1.45 it's obviously fine.

poliorcetics commented 1 year ago

TOML 0.7 has an MSRV or 1.60: https://github.com/toml-rs/toml/blob/main/crates/toml/Cargo.toml#L18, is that okay ?

nabijaczleweli commented 1 year ago

I wouldn't say that delights me per se, since bullseye ships 1.48, but apparently bookworm will soon enough land with 1.63, so meh.

Let's see how https://ci.appveyor.com/project/nabijaczleweli/rust-embed-resource/builds/46642053 fares.

nabijaczleweli commented 1 year ago

Applied as 379654f780f9d151518f43c7ef7c26fd0bcd74be and 7d56960ba8f77acfd6c9bdf9cbbd07621eafb940, released in v2.1.1.