search

nabil6391 / graphview

Flutter GraphView is used to display data in graph structures. It can display Tree layout, Directed and Layered graph. Useful for Family Tree, Hierarchy View.
MIT License
420 stars 114 forks source link

Dart Migration w/o annotations #32

Closed MateusAmin closed 3 years ago

MateusAmin commented 3 years ago

https://github.com/nabil6391/graphview/issues/21

Not tested, but passes analysis. I am using in my own project and will follow up with opinions.

I used the Dart migration tools without any annotation coloring the results. Then made some patches here and there. You may want to go through it yourself as there is an opportunity to make the API a bit safer by shifting types to be non-nullable. Without annotations the migration tends to just make things explicitly null able.

Also, probably a good idea to major version bump and add a -beta tag to the version if you feel this is still in beta.

MateusAmin commented 3 years ago

It works with some minor use changes, would need to update the examples.

Honestly, this is a pretty low effort PR from my end. If someone has time to really think things through that would be best.

nabil6391 commented 3 years ago

hi @MateusAmin , really busy month going on for me, I wont be able to CR soon. Hope you understand

MateusAmin commented 3 years ago

Absolutely. If I where less busy I would have made you a cleaner PR. Hopefully, some other users with more time might step in.

With my use case I am going to end up with a custom library but this really helped me get off to a quick start. I am grateful for all the work you put into this so far.

stefanschaller commented 3 years ago

What is the progress right now? My company would like to use / fork this repo to do something awesome (When Null-Safefy is done and stable)

Is any help needed?

nabil6391 commented 3 years ago

I have pushed some codes to master for a change. After merging I will make this null safe

vin-fandemand commented 3 years ago

Hi folks, any update on the null safe release?

nabil6391 commented 3 years ago

NullSafety version has been released guys, thanks for the wait Version: 1.0.0-nullsafety.1