search

nabilfreeman / ios-universal-webview-boilerplate

Universal Swift-based boilerplate for a web app.
804 stars 63 forks source link

Linking to a web page outside of the project opens in same webview #2

Open nabilfreeman opened 9 years ago

nabilfreeman commented 9 years ago

This is a problem as there are no browser controls.

Ideal solution would be to instruct the webview to open non-local links or whatever in Safari... don't know how to do this yet.

jstart commented 9 years ago

Probably would want to just check if the URL is external, then either use UIApplication.openURL or SFSafariViewController. Would you accept a PR that added a configurable way to use one of these two approaches?

nabilfreeman commented 9 years ago

@jstart absolutely!

PatrickBK commented 8 years ago

Any news on this issue? Do external links, not on the defined domain, open in Safari yet?

nabilfreeman commented 8 years ago

hey @PatrickBK, not yet! i don't have time to add it as my day job isn't currently iOS stuff.

If somebody would like to patch this, please feel free :grin: ( @jstart ? )

PatrickBK commented 8 years ago

Hi @nabilfreeman, I understand and thanks for putting it out there as is :-)