nabla-c0d3 / nassl

Experimental OpenSSL wrapper for Python 3.8+ and SSLyze.
GNU Affero General Public License v3.0
39 stars 35 forks source link

Can nassl use system-provided zlib? #109

Closed ZhongRuoyu closed 1 year ago

ZhongRuoyu commented 1 year ago

Hi! Homebrew maintainer here. We noticed nassl is building its own zlib and OpenSSL instead of using the system-provided ones. While the reason for building OpenSSL was justified in #64, I wonder if it is possible not to build its own zlib? Thanks!

carlocab commented 1 year ago

Note that the API of Zlib is very stable (which is kind of a requirement given how widely used it is), so there should be essentially no additional maintenance burden from allowing use of a system copy of Zlib.

nabla-c0d3 commented 1 year ago

Hello!

essentially no additional maintenance

That's possible (even likely), but I won't have time to add support for customizing the build commands, so that the system-provided Zlib is used instead.