Scan hangs forever when "invalid padding" error occurs

nabla-c0d3 / sslyze

Fast and powerful SSL/TLS scanning library.

GNU Affero General Public License v3.0

3.25k stars 446 forks source link

Scan hangs forever when "invalid padding" error occurs #632

Closed FestiveKyle closed 5 months ago

FestiveKyle commented 9 months ago

Describe the bug

If an OpenSSLError is raised for invalid padding, the scan hangs forever. There is an illegal padding in the _HANDSHAKE_REJECTED_TLS_ERRORS, but not a invalid padding.

Expected behavior

The error should be caught.

Python environment (please complete the following information):

OS: Ubuntu 22.04
Python version: 3.10.12

Additional context

Image of error:

nabla-c0d3 commented 7 months ago

Thanks for the fix 👍😀

nabla-c0d3 commented 5 months ago

Fixed in v6.0.0.