search

nabla-c0d3 / sslyze

Fast and powerful SSL/TLS scanning library.
GNU Affero General Public License v3.0
3.25k stars 446 forks source link

Add support for custom SMTP EHLO hostname #636

Closed mxsasha closed 6 months ago

mxsasha commented 8 months ago

Some servers require that the SMTP EHLO hostname matches the reverse of the connecting client. This change allows Python clients to do that.

Did consider whether this was better placed in ScanCommandsExtraArguments, but I kept it simple and followed the flow of xmpp_to.

Also all includes s small doc fix: tls_wrapped_protocol->tls_opportunistic_encryption.

nabla-c0d3 commented 7 months ago

Hello! Thanks for the PR 😀. Before I look into it, do you know of an SMTP server on the Internet that I could connect to to try these changes ? You can email it to me if you have one. Thanks!

mxsasha commented 6 months ago

Not any that I'm aware of, though any SMTP server that accepted the old EHLO, which was not attached to the hostname, should accept a different one.

https://tcpbin.com/ has some support but would break the actual test, or https://github.com/rcx/tcpbin but the public instance of that has died.

mxsasha commented 4 weeks ago

Not sure why this one was closed? Is the feature or patch rejected?

nabla-c0d3 commented 4 weeks ago

Not sure either as I don't recall making the decision to close this without any comment or reply.

Maybe it was closed automatically because I deleted the target branch (as this PR didn't make the cut for the v6.0.0 release, which is what the branch was about)?