search

nabla-c0d3 / sslyze

Fast and powerful SSL/TLS scanning library.
GNU Affero General Public License v3.0
3.19k stars 445 forks source link

Build docker image for Mac (arm64) #648

Closed jamest-pin closed 1 week ago

jamest-pin commented 2 months ago

Is your feature request related to a problem? Please describe. I want to run the docker image locally at work first before deploying in CI. Currently I get this:

~$ docker pull nablac0d3/sslyze:6.0.0
6.0.0: Pulling from nablac0d3/sslyze
no matching manifest for linux/arm64/v8 in the manifest list entries

Describe the solution you'd like I'd like to be able to pull the docker image from docker hub and run it on my Mac M series. This could be accomplished by adding one keyword , linux/arm64 to your github actions workflow.

     - name: Build and Push
        uses: docker/build-push-action@v2 # <<<<<<<< fyi, v5 is the latest.
        with:
          context: ./
          file: ./Dockerfile
          platforms: linux/amd64, linux/arm64 # <<<<<<<<< update here

Describe alternatives you've considered I attempte to git clone and docker build . myself, but got some python build script error which is above my head to resolve.

Additional context No additional context. Thanks in advance.

nabla-c0d3 commented 1 week ago

Hello, I don't know Docker well enough to figure this out...

jamest-pin commented 1 week ago

Hello, I don't know Docker well enough to figure this out...

Hi, @nabla-c0d3 all you need to do is add the single keyword onto the line I recommended. There's not figuring out anything 😢

Just edit this line only: https://github.com/nabla-c0d3/sslyze/blob/761892bf6a613726f272eb4e19b33faee2272b6f/.github/workflows/release_to_docker.yml#L42

Add this onto the end of the line: , linux/arm64 that's it 😃

gostega commented 1 week ago

@nabla-c0d3 I did a PR for you in case it helps: https://github.com/nabla-c0d3/sslyze/pull/655