search

nabonitasen / pe

0 stars 0 forks source link

Whitespaces allow for duplicate names in "addPerson" command. #4

Open nabonitasen opened 11 months ago

nabonitasen commented 11 months ago

UG states that duplicate names not allowed. This is not sensitive to white spaces (ie if the same name with two whitespaces in between first and last name is added, it is accepted), which could be a common user error.

Screenshot 2023-11-17 at 4.28.38 PM.png

Screenshot 2023-11-17 at 4.30.42 PM.png

nus-se-script commented 11 months ago

Team's Response

Same issue, lies in the "-name NAME" parameter taken in by lesson and person

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Name accepts more than 1 whitespace in between

Expected: Name does not accept more than 1 whitespace that the user might have typed in by accident

Actual: Name accepts more than 1 whitespace, which can confuse the user when he/she is looking for that name again. This also allows the same name to be added again, which is against the UG

Screenshot 2023-11-17 at 4.40.13 PM.png

[original: nus-cs2103-AY2324S1/pe-interim#4261] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

We agree that this is allowed in our app. However, we feel that the severity should not be medium, but rather low. It is very rare rather than occasional situation that the user would type in the same person multiple times but with different spaces. This fits into the severity labels in the textbook:

image.png

Furthermore, our find feature allows searching of partial names, hence searching for Leah would return all of them, hence the user would realise that they duplicated it. Also, the argument that the user might add a person of Leah Soh with 2 spaces, and again find for Leah Soh with 2 spaces is even rarer.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]