nabonitasen / pe

0 stars 0 forks source link

Date range too wide #5

Open nabonitasen opened 11 months ago

nabonitasen commented 11 months ago

Private tuition teachers will only have classes scheduled for up to a specific amount of time (max 12 years i guess). should be some limit to acceptable dates, since tutor probably has no reason to hold classes in 2123 if they are still teaching then.

Screenshot 2023-11-17 at 4.43.19 PM.png

soc-se-bot commented 11 months ago

Team's Response

There is no strong reason of restricting such user input when the user deliberately input so as well.

The only benefit would be a very slight reduction on the risk of inputing wrong year.

But our parser for date is already carefully designed to minimize unintentional input of wrong date.

User could choose to input just DD or MM/DD or YY/MM/DD or YYYY/MM/DD.

Only in the last case when user deliberately input 2123/01/24 could lead to the case in the screen shot. So the risk of filling a wrong year by mistake is minimized, as If user what to input 2023/01/24, the user simply need to input 01/24 or 23/01/24 rather than 2123/01/24

Therefore, there is no strong reason to pose this restriction, which might be taken as too restrictive by some other users/testers.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]