search

nabrosimoff / aio_tiny_healthcheck

Tiny asynchronous implementation of healthcheck provider and server
Apache License 2.0
12 stars 2 forks source link

Add `aiohttp` into package dependencies. #2

Open LittleYenMin opened 4 years ago

LittleYenMin commented 4 years ago

ERROR

from aio_tiny_healthcheck.checker import Checker
  File ".../lib/python3.7/site-packages/aio_tiny_healthcheck/__init__.py", line 5, in <module>
    from .http_server import HttpServer
  File ".../lib/python3.7/site-packages/aio_tiny_healthcheck/http_server.py", line 1, in <module>
    from aiohttp import web

In my source code, I have only installed this package and this error shows up. It seems in this package it doesn't specify the aiohttp in relation dependencies of this package. To solved this error, I suggested that add aiohttp to this package dependencies.

Olegt0rr commented 2 years ago

@LittleYenMin, author shouldn't do it, cause aiohttp is not a dependency for this app. Everybody chose server app on hist taste and flavour. Sanic for example :)