Annotations are lost when the new secret is created

nabsul / k8s-ecr-login-renew

Renews Docker login credentials for an AWS ECR container registry.

MIT License

207 stars 51 forks source link

Annotations are lost when the new secret is created #15

Closed xavidop closed 3 years ago

xavidop commented 3 years ago

Hello,

I was noticed that the metadata is lost when the new secret is created.

nabsul commented 3 years ago

This is by design. The tool always deletes the existing secret and recreates it.

But I'm open to changing the behaviour if it doesn't have any downsides.

xavidop commented 3 years ago

I think the only change that has to be done is the content of the secret. The other data could be important like in my case. I have some key annotations. There are a nes added automatically by helm and other ones used by Replicator to replicate a secret in multiple namespaces. What do you think?

nabsul commented 3 years ago

Sounds reasonable to me. It should be a small change. I'll try to get it done this weekend or next.

xavidop commented 3 years ago

Okay! Thank you so for your understanding!

nabsul commented 3 years ago

v1.4 is getting published shortly. Be sure to grant "update" permissions to the service account so that it can perform this new operation.