🚸 Improve Usability for Multiline Target Namespace Declaration

[jeremyruffell]

Summary

Added the ability to use Multiline YAML to declare Target Namespaces. When Declaring a large amount of namespaces having all the namespaces in one line can become hard to read, format and track on git.

I have added the formatNamespaceList function that replaces a new line with a comma & removes all whitespace. This now means we can use Multiline YAML whilst also retaining backwards compatibility and not introduce any breaking changes.

Examples

• Original Method (Single Namespace)

• name: TARGET_NAMESPACE value: namespace1

• Original Method (Multi-Namespace)

• name: TARGET_NAMESPACE value: namespace1,namespace2,namespace3

• New Multiline Method (Multi-Namespace)

• name: TARGET_NAMESPACE value: | namespace1 namespace2 namespace3 namespace4 namespace5

Testing

I have tested this using both the tests provided in this repo & using this application with these changes in a cluster with 30+ namespaces.

[nabsul]

I took a quick look at the change, and this looks super clear, straight forward, and fully backwards compatible. Thanks!

I might not get around to fully testing this till the weekend, but I don't expect to have any concerns around publishing this in an update.

(also, don't mind the failed build, that's probably my fault)

[jeremyruffell]

I took a quick look at change, and this looks super clear, straight forward, and fully backwards compatible. Thanks!

I might not get around to fully testing this till the weekend, but I don't expect to have any concerns around publishing this in an update.

(also, don't mind the failed build, that's probably my fault)

Cheers! Il send a PR your way fixing up the actions when I get a chance!

[nabsul]

Actually, should we add \t and r to the character list?

[nabsul]

Probably worth converting to a for loop at that point.

[jeremyruffell]

Actually, should we add \t and r to the character list?

Now you say it yep makes sense! want me to add these to the formatNamespaceList func:

• Strip \r
• Strip \t

And update this PR?

[nabsul]

I double checked the k8s docs to make sure that none of those characters are allowed in a namespace: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/

[jeremyruffell]

Updated PR to strip:

• \t
• \v
• \r

I will push up some changes to the Actions and Documentation on how to use with Multiline YAML soon 💜

[nabsul]

I messed up the history tracking, but everything in this PR is merged to #27 in preparation for releasing a new version of the tool.