search

nabsul / k8s-ecr-login-renew

Renews Docker login credentials for an AWS ECR container registry.
MIT License
205 stars 49 forks source link

feat: add podAnnotations to the cronjob #39

Closed xavidop closed 1 year ago

xavidop commented 1 year ago

This is a little bit of high prior PR. This adds the ability to add custom annotations to the pods that the cronjob creates. This is needed for cronjobs executed in namespaces with a service mesh i.e linked and we don't want to add these pods to the mesh. If we cannot add pod annotation and disable the mesh, the mesh sidecar will be running forever and the job will not finish

xavidop commented 1 year ago

@nabsul @devec0 let me know what you think! it is high prior on my side :)

nabsul commented 1 year ago

@xavidop This looks totally reasonable to me, and I can get it merged and published soon. I only had one minor change request, just to keep the resulting YAML identical when there are no annotations to be added.

xavidop commented 1 year ago

@nabsul nice!! I just pushed your recommendation! good catch!

xavidop commented 1 year ago

Thanks @nabsul for merging this! Do you know when is this going to be available in your helm chart repository?

nabsul commented 1 year ago

Helm repository updated: https://nabsul.github.io/helm/index.yaml

nabsul commented 1 year ago

Please try it out, I haven't tested it. I'll leave that up to you :-)

xavidop commented 1 year ago

just deployed it on my cluster using Terraform and works like charm!! thank you so much!