search

naca-nyan / repertoire

https://syncroom-repertoire.web.app
1 stars 1 forks source link

change songID generate method to avoid ':' redudaunt bug #11

Closed takahyon closed 2 years ago

takahyon commented 2 years ago

Change songID generate method to avoid ':' redudaunt bug Tested local npm enviroments and no probrem detected, but I can't test on firebase, please test at staging or nacanyan's environment?

naca-nyan commented 2 years ago

Interesting. But changing key breaks consistency of existing data. Migration may be needed before merging this.

takahyon commented 2 years ago

Please give me sample of current storage json? or location which contains it. Thx

naca-nyan commented 2 years ago

I ended up using only URLs to generate songId (#14). The bug being fixed, I will close this PR. Thank you for contributing!