nachetecanon / google-enterprise-connector-manager

Automatically exported from code.google.com/p/google-enterprise-connector-manager
Apache License 2.0
0 stars 0 forks source link

Incorrect use of ConnectorPersistentStoreAware #238

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Implement a subclass of ConnectorPersistentStoreFactory that uses a document 
store or change the class itslef to use one.
2. Use a file connector which isn't ConnectorPersistentStoreAware
3. Define and run a file connector instance

What is the expected output? What do you see instead?
There should be entries in the H2 document store table.
No entries are in that table.

What version of the product are you using? On what operating system?
2.8.4 on Linux

Please provide any additional information below.

The problem is in ConnectroCoordinatorImpl.setDatabaseAccess(). Here the 
interface ConnectorPersistentStoreAware is used to decide whether a document 
store should be used at all. Instead this should only be used to decide whether 
to call connector.setDatabaseAccess(). That is, only this line should be 
bracketed with the if (connector instanceof ConnectorPersistentStoreAware) 
check.

Original issue reported on code.google.com by fredkie...@gmx.de on 8 Aug 2012 at 2:34

GoogleCodeExporter commented 8 years ago
This works as designed.  We only maintain a DocumentStore for Connectors that 
request it.  Neither the Connector Manager, nor the GSA make use of it at this 
time.  In fact, no Google connectors use the DocumentStore at this time either.

You have also found that the DocumentStore functionality was intentionally 
disabled in version 2.8 (and is still disabled in 3.0), as it is an incomplete 
implementation.

However, if the DocumentStore is re-enabled in the future, we will consider 
this request.

Original comment by Brett.Mi...@gmail.com on 8 Aug 2012 at 6:07