nachoaIvarez / flexbox-react

Unopinionated, standard compliant flexbox component. No propietary APIs. Nothing but flexbox.
Other
319 stars 49 forks source link

- Added "className" to typings for typescript #31

Closed paulspiteri closed 7 years ago

paulspiteri commented 7 years ago

27

paulspiteri commented 7 years ago

@nachoaIvarez slam it home? 🔢

nachoaIvarez commented 7 years ago

Hey @paulspiteri! Thank you for your contribution. I'm currently traveling. I'll review your change when I'm back. Talk to you then. On Wed, Apr 12, 2017 at 08:24 Paul Spiteri notifications@github.com wrote:

@nachoaIvarez https://github.com/nachoaIvarez slam it home? 🔢

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/nachoaIvarez/flexbox-react/pull/31#issuecomment-293559899, or mute the thread https://github.com/notifications/unsubscribe-auth/AG6vNrLfq1o2tz0XFHYwAW5lhc5wYEi9ks5rvMJjgaJpZM4MqPsd .

nachoaIvarez commented 7 years ago

Btw, that's next week. On Thu, Apr 13, 2017 at 12:26 Ignacio Álvarez ignacioalvarez92@gmail.com wrote:

Hey @paulspiteri! Thank you for your contribution. I'm currently traveling. I'll review your change when I'm back. Talk to you then. On Wed, Apr 12, 2017 at 08:24 Paul Spiteri notifications@github.com wrote:

@nachoaIvarez https://github.com/nachoaIvarez slam it home? 🔢

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/nachoaIvarez/flexbox-react/pull/31#issuecomment-293559899, or mute the thread https://github.com/notifications/unsubscribe-auth/AG6vNrLfq1o2tz0XFHYwAW5lhc5wYEi9ks5rvMJjgaJpZM4MqPsd .

nachoaIvarez commented 7 years ago

What's the purpose of the .gitattributes file addition @paulspiteri? Looks good to merge but first I want your explanation for that! Thanks.

paulspiteri commented 7 years ago

Added .gitignore file to explicitly checkout in LF text mode which is required by the linter (failed on Windows otherwise)

paulspiteri commented 7 years ago

I can take that out if you like. Probably the linter shouldn't care, though?

nachoaIvarez commented 7 years ago

Merged and published @paulspiteri.