Bugfixes for custom newline characters and files containing NULL characters

nacholibre / node-readlines

Read large text files line by line (synchronous) for Node.js

MIT License

161 stars 28 forks source link

Closed smitterz closed 4 years ago

smitterz commented 5 years ago

Fixed a wrong behavior in the case when a file contains a NULL character inside. Test provided.

Fixed a hardcoded newline character in one place. Trivial fix, so no additional tests for this fix.

ingalls commented 4 years ago

@nacholibre Any chance you can review and merge this?

nacholibre commented 4 years ago

@nacholibre Any chance you can review and merge this?

Done

ingalls commented 4 years ago

@nacholibre Appreciate it, thanks a ton!