search

nacimgoura / instagram-profilecrawl

:computer: Quickly crawl the information (e.g. followers, tags, etc...) of an instagram profile. No login required!
MIT License
121 stars 30 forks source link

Make Selenium an optional dependency #20

Closed marcospgp closed 6 years ago

marcospgp commented 6 years ago

19

nacimgoura commented 6 years ago

Thanks :wink:

marcospgp commented 6 years ago

There's a bit of a downside to this, being that there will be an additional step for users who want to use the Selenium method. I don't see a better way around it though, any ideas?

nacimgoura commented 6 years ago

I don't know if it is possible to define which method to use during installation. There is also another method: when the user uses selenium, it is installed at that time.

marcospgp commented 6 years ago

I don't know if it is possible to define which method to use during installation.

I don't think there is, at least without altering the installation commands a little bit. Would end up being the same as installing selenium optionally.

There is also another method: when the user uses selenium, it is installed at that time.

That is an option, we would have to check if selenium is installed and if not, run the commands. We can keep it listed as an enhancement.

nacimgoura commented 6 years ago

Show issue #21