nacimgoura / instagram-profilecrawl

:computer: Quickly crawl the information (e.g. followers, tags, etc...) of an instagram profile. No login required!
MIT License
121 stars 30 forks source link

No treatment when posts > 1000 #4

Closed laurent-d closed 7 years ago

laurent-d commented 7 years ago

Hi @nacimgoura ! When the number of posts is bigger than 1000, your script stop without treatment. instagram-profilecrawl jamieoliver ✔ Profile successfully loaded for jamieoliver! ✔ File created with success!

laurent-d commented 7 years ago

I think it the same for the likes, if the likes is bigger than 999, the json display null.

nacimgoura commented 7 years ago

Hi again @laurent-d . When the number is too high it is replaced by a letter, which I did not know. I have modified and it will have to be good. Also, If there are too many comments, the number is invalid. I wasn't able to correct that.

laurent-d commented 7 years ago

@nacimgoura Thanks for support. It seems does not make effect but it make an error about the replace fonction : instagram-profilecrawl bigmammagroup ✔ Profile successfully loaded for bigmammagroup! ✖ number.replace is not a function

nacimgoura commented 7 years ago

I work on a solution, I will notify you when it will be good.

nacimgoura commented 7 years ago

It seems that it works now. I'm waiting for your feedback!

laurent-d commented 7 years ago

Hi @nacimgoura that's work 👍 but all like field are at 0 👎 Thanks a lot for the amazing support. Have a good day

nacimgoura commented 7 years ago

Hi @laurent-d , I can't reproduce the bug. What account do you use?

laurent-d commented 7 years ago

It seems it's the same issue of thousand post, when the number of like > 999, it write 0 I test on these accounts : alainducasse, bigmammagroup For normal account with less like sometimes it works : sixty_five_spoons sometimes not works : cam.caron Very strange, i make new install of your script to be the last version (1.3.0)

nacimgoura commented 7 years ago

I tested with bigmammagroup, alainducasse and emmawatson, too. I didn't encounter any worries. I just made a new commit with examples : https://github.com/nacimgoura/instagram-profilecrawl/tree/master/examples I tested several times, I have 0 likes only for the videos, which is normal. Update the program and test with alainducasse or emmawatson. They do not have a lot of posts, so the script should be fast. I await your feedback.

laurent-d commented 7 years ago

Incomprehensible !!! : http://laurent.la/profile-emmawatson.json I made a fresh update of nodejs (v6.10.2) and of your app (1.3.1). My OS is Sierra, Chrome is updated (58.) Sorry about all these issues. Hope that it works for others.

nacimgoura commented 7 years ago

I finish adding a new feature and test with the same version of nodeJS as you. I was testing with nodeJS 4.8 to test compatibility. I use 1.3.1 for app and 58 for Chrome like you, but I use Linux. I'll keep you informed.

nacimgoura commented 7 years ago

@laurent-d , I have updated the program, maybe it will work for you now. Also, I added the example for emmawatson

laurent-d commented 7 years ago

Nop :(, it's a mac issue perhaps

nacimgoura commented 7 years ago

Completely remove the program and download it again. Behavior should be the same depending on the os. But I'll try something and tell you when it's good.

nacimgoura commented 7 years ago

@laurent-d Can you clone this project and replace index.js with https://gist.github.com/nacimgoura/e9a743e02f15f5a33f637631424f0830 and test with : ./index.js emmawatson

Tell me if you still have the number of likes equal to 0.

laurent-d commented 7 years ago

@nacimgoura , It seems work great !!! Thanks a lot. See : http://laurent.la/profile-emmawatson.json It miss a 0 for thousand of likes , 799K write 79900 but it works. Some of comments are null but its a great improvement 🥇 Thanks again

nacimgoura commented 7 years ago

The null comments have gone randomly, which is really strange. I don't have this problem but I will think about a fix.

laurent-d commented 7 years ago

I made a second test with alainducasse : http://laurent.la/profile-alainducasse.json Only likes < 999 works Very strange. Take your time for the issue !

nacimgoura commented 7 years ago

Hi @laurent-d , Can you test with the new version? I can't really test on my computer because I don't encounter the bug but I tried to understand its origin. I await your feedback.

laurent-d commented 7 years ago

Hi @nacimgoura ! Yes sure, for emma, likes works like a charm, comments bug at the third post (i tried twice) any memory issue ?) : http://laurent.la/profile-emmawatson.json for alain : likes don't work but comments are goods very strange : http://laurent.la/profile-alainducasse.json For smaller accounts its good Do not hesitate if you want more test!!

nacimgoura commented 7 years ago

I finally understand where it comes from, I'll try to correct it if that's what I think.

laurent-d commented 7 years ago

Good news 👍 👍 👍 👍 👍 👍

nacimgoura commented 7 years ago

@laurent-d , I released the new version. If it works now it means that the error came from the fact that your chrome browser is in French and the numbers were displayed differently than in English. And that's also why I couldn't have the error. I'm French too but my browser is in English.

laurent-d commented 7 years ago

@nacimgoura. It works 💯
Fabulous thanks for you awesome work and support !!! The error on the python script is surely due to this. I will make make i tiny script to use the data and order it. Thanks again

nacimgoura commented 7 years ago

No worries, it allowed me to correct the bugs. If you are thinking of improvements, you can make a pull request.