nacmartin / phpexecjs

Run JavaScript code from PHP
MIT License
146 stars 26 forks source link

Add phpunit dev dependency, upgrade test suite #9

Closed roydejong closed 5 years ago

roydejong commented 5 years ago

Hi, I'm relying on this project and while I was debugging some stuff I made some changes in my fork. Hopefully this PR is useful in some way.

This PR cleans up testing by making the following changes:

roydejong commented 5 years ago

It looks like this build fails for PHP 7.0 and 7.1. Both these versions of PHP are no longer supported (7.1 only gets security updates for another 2 months), so I'll add a commit that retargets Travis to currently supported versions only.

nacmartin commented 5 years ago

Thanks for pouring some love on this project, @roydejong :)