nacnudus / tidyxl

Read untidy Excel files in R https://nacnudus.github.io/tidyxl/
https://nacnudus.github.io/tidyxl/
Other
248 stars 21 forks source link

special characters in sheet names #37

Closed luisDVA closed 6 years ago

luisDVA commented 6 years ago

Hi Duncan, I was working with some xlsx files that had sheet names in Spanish and I noticed that the names with special characters were getting garbled in the 'sheet' variable of the output data frame. I'm assuming it's an encoding issue. Is this something that could be specified as an argument during the file import?

thanks for the package!

nacnudus commented 6 years ago

Hi! I thought this was fixed in #12. Can you provide an example? I've just tested with µ, and it works.

luisDVA commented 6 years ago

I just tried to recreate the issue on my work computer (running Linux Mint) but now the sheet names show up fine. The garbling seems to only happen in Windows, I need to check on a different machine.

nacnudus commented 6 years ago

Ah, Windows. What version? I have a bad feeling this came up before and I took a shortcut hoping it would go away.

luisDVA commented 6 years ago

I run a Windows 10 partition. I'll get the session info for my laptop and for my collaborator's system.

nacnudus commented 6 years ago

Thanks. I'm about to be offline for a week but I will get back to this.

nacnudus commented 6 years ago

I can't reproduce this with µ on Windows 10 so I'll close the issue. Feel free to reopen with a reproducible example.

luisDVA commented 6 years ago

I was also unable to reproduce this on Windows 10 and couldn't track down the student that was having issues with the encoding. Thanks for the replies!