search

nacnudus / tidyxl

Read untidy Excel files in R https://nacnudus.github.io/tidyxl/
https://nacnudus.github.io/tidyxl/
Other
246 stars 20 forks source link

apply* formats should default to false #73

Closed nacnudus closed 3 years ago

nacnudus commented 3 years ago

~When <cellXfs><xf><applyFill> and similar are absent, they currently default to true, which causes crashes when <cellXfs><xf><fontId> is also absent. The should default to false. Unfortunately, this breaks a few tests, and issues lots of warnings.~

When certain styles such as <cellXfs><xf><fontId> is absent, then the fact that <cellXfs><xf><applyfont> defaults to true (because that's what LibreOffice assumes when it doesn't bother writing them to the file) causes a segfault.

Originally reported in #71 by @e-mcbride, where the attached example file was provided. raw-condensed-completeonly-xl.xlsx

nacnudus commented 3 years ago

Fixing in #74

nacnudus commented 3 years ago

@e-mcbride please reopen if the problem still occurs. Thanks for reporting and for your patience waiting for a fix.