search

nacnudus / tidyxl

Read untidy Excel files in R https://nacnudus.github.io/tidyxl/
https://nacnudus.github.io/tidyxl/
Other
246 stars 20 forks source link

Default apply* formats to false (fix #73) #74

Closed nacnudus closed 3 years ago

nacnudus commented 3 years ago

There's a test "libreoffice 'applyFill' defaults to true (it is never defined)", so perhaps defaulting to false is also wrong. Maybe the missing <fontId> etc. ought to have defaults instead.

nacnudus commented 3 years ago

~devtools::test()~ testthat::test_local() segfaults (locally) even when xlsx_cells("examples.xlsx") is the only line in the only file in tests/testthat, yet the following code runs fine:

setwd("tests/testthat")
tidyxl::xlsx_cells("examples.xlsx")