Don't interpret uppercase E as a date format (fix #52)

nacnudus / tidyxl

Read untidy Excel files in R https://nacnudus.github.io/tidyxl/

https://nacnudus.github.io/tidyxl/

Other

246 stars 20 forks source link

Don't interpret uppercase E as a date format (fix #52) #75

Closed da11an closed 2 years ago

da11an commented 2 years ago

Fix Issue #52

While e and ee are for era or year date entry, E is for scientific notation.

nacnudus commented 2 years ago

Thanks @da11an, I'm grateful for this PR. Please can you also add a line to NEWS.md referencing your GitHub handle, the issue and this PR.

Just to note that I checked the ECMA and it does seem that only lowercase e and ee are interpreted as dates, and only in Japanese locales. If I'd realised that this was a one-line fix, I'd have done it ages ago! Thank you for investigating.

nacnudus commented 2 years ago

Thanks! Sorry for the delay merging it.