search

nacos-group / nacos-sdk-go

Nacos client in Golang
Apache License 2.0
1.08k stars 333 forks source link

Log parameters of `ClientConfig` will not take effect at all. #747

Open wangjian-pg opened 2 months ago

wangjian-pg commented 2 months ago

What version of nacos-sdk-go are you using?

The master branch of the repo.(commit ID: 6dd8997f7a0270ca05bf818570ec220c0fe7b127)

After merging #722, since the logger package's init function already sets the global logger to a non-nil value, the common.logger.InitLogger function will always return prematurely, making the logging parameter ClientConfig have no effect at all.

Please check the following code lines:

We may need to review the code more carefully before accepting the PR.

binbin0325 commented 1 month ago

Can you submit pr to fix it

dingyang666 commented 4 weeks ago

Can you submit pr to fix it

I also noticed this issue and submitted a PR to fix it. PTAL https://github.com/nacos-group/nacos-sdk-go/pull/759