search

nadako / Ash-Haxe

Port of Ash entity framework to Haxe
Other
131 stars 37 forks source link

Prevent addSystem/removeSystem during update #34

Closed gogoprog closed 8 years ago

gogoprog commented 8 years ago

Hello,

I had very weird and hard-to-debug issues when I was not using the updateComplete signal. So I think it should be forbidden to add or remove systems during the engine update.

What do you think?

nadako commented 8 years ago

This makes sense to me, however it's not implemented in upstream (original ash) and technically this is a breaking change, because there might be some weird cases when one wants to insert a system into update loop so that it's executed in current iteration...

gogoprog commented 8 years ago

You are right it should not differ from the original Ash

jamiltron commented 8 years ago

Yeah I think the official word from Richard Lord, if I'm reading this issue correctly: https://github.com/richardlord/Ash/issues/39, is to just use updateComplete.