search

nadar / quill-delta-parser

A PHP library to parse and render Quill WYSIWYG Deltas into HTML - Flexibel and extendible for custom elements.
MIT License
122 stars 20 forks source link

Fix issue #87 #88

Closed shuedo closed 7 months ago

shuedo commented 7 months ago

This pull request addresses the issue described in #87, where a line break preceding a list containing inline attributes results in improper HTML formatting.

this closes #87

nadar commented 7 months ago

Looks great! Could you please add a changelog entrie? otherwise i will do it for you. next patch version would be 3.4.2

shuedo commented 7 months ago

Looks great! Could you please add a changelog entrie? otherwise i will do it for you. next patch version would be 3.4.2

Done!

nadar commented 7 months ago

Thank you so much @shuedo! Perfect issue description, perfect error finding, perfect pull requesting with testings and changelog! If every pull request would be this way, the world would be a better place for sure! thanks :earth_asia:

https://github.com/nadar/quill-delta-parser/releases/tag/3.4.2

shuedo commented 7 months ago

Thanks, @nadar! Really appreciate the encouragement. I'm excited to keep contributing in the future! 😄