search

nadavshatz / ember-cli-foundation-sass

Automatically sets up Foundation 5 SASS in your Ember CLI app.
https://www.npmjs.org/package/ember-cli-foundation-sass
MIT License
68 stars 18 forks source link

Add-on configuration in Brocfile? #6

Closed bx2 closed 9 years ago

bx2 commented 10 years ago

Wouldn't it be clearer if the config for Foundation would be added to the config/environment file? I am not sure what the best practice is, but as I understand it broccoli is loading external modules, while configuration one can provide from wherever right?

What do you think?

Globegitter commented 10 years ago

You mean the config of which foundation modules (top bar, etc) are being loaded? This config really just is syntactic sugar over the necessary app.import statements, so I do think the Brocfile is the right place.

Globegitter commented 9 years ago

Closing for now. Let me know if you have any more thoughts.