search

nadavshemesh / angular2-click-to-edit

click on a data-binding text to make it editable, easy to implement and very useful!
20 stars 7 forks source link

Complete overhaul of this project to make it compatible to Angular 4.… #3

Closed ThorstenBux closed 7 years ago

ThorstenBux commented 7 years ago

…2.x. Example is a project generated with ng new and enhanced using the agular2-click-to-edit components. Library compiles using new tsconfig.json.

Works fine for me. Please let me know if you are going to make a new npm release otherwise I'll do it under a new name.

ThorstenBux commented 7 years ago

Oh, I was just going to rework that again. Sorry for that but somehow I didn't change your latest changes from master. Meaning the permission tag is lost and the selectors are all broken. Sorry for that :-/

nadavshemesh commented 7 years ago

Hey dont worry about it i can revert it, you think you could make it work? i really appreciate you stepping forward and trying to update i unfortunaly didnt have much time lately..

ThorstenBux commented 7 years ago

I think I can. But I don't have much experience with creating an NPM component. I just wonder why I didn't pick up the latest master. At the moment it looks like a big mess. But I try to clean it up 👍

nadavshemesh commented 7 years ago

awesome! i think it will be much more useful to people if its compatible with angular 4 and to be honest i don't have much experience either :)