search

nadchif / adobe-brackets-encode-decode

Adobe Brackets IDE Extension that lets you to convert text selections to and from various formats
https://registry.brackets.io/
GNU General Public License v3.0
9 stars 15 forks source link

Morse code converter added Fix #24 #25

Closed okandavut closed 4 years ago

okandavut commented 4 years ago

Fix #24

okandavut commented 4 years ago

I will check for this issues i could not run to script build i will try on macos.

Shankhanil commented 4 years ago

Great work. That was really quick of you. There are some failed checks. You can fix them by using eslint --fix ./src/* on the project folder and committing the changes again.

okandavut commented 4 years ago

Great work. That was really quick of you. There are some failed checks. You can fix them by using eslint --fix ./src/* on the project folder and committing the changes again.

I really like this project and i could not run to script on windows but i will try on macos now and i will solve :)

okandavut commented 4 years ago

@nadchif I added control for unsupported characters for encode/decode operations. Can you check it again?

nadchif commented 4 years ago

Thank you for the prompt response. I will check it out and get back to you soon ☺

Shankhanil commented 4 years ago

@nadchif I added control for unsupported characters for encode/decode operations. Can you check it again?

@okandavut We will soon add a series of unit tests for all the available encoders-decoders. Thank you so much for your contribution

nadchif commented 4 years ago

@all-contributors please add @okandavut for code

allcontributors[bot] commented 4 years ago

@nadchif

I've put up a pull request to add @okandavut! :tada: