search

nadchif / adobe-brackets-encode-decode

Adobe Brackets IDE Extension that lets you to convert text selections to and from various formats
https://registry.brackets.io/
GNU General Public License v3.0
9 stars 15 forks source link

Adding encoding/decoding for ASCII #39

Closed unguest closed 4 years ago

unguest commented 4 years ago

I added a context menu option for ASCII 🚀 !

unguest commented 4 years ago

I don't understand why the test isn't passing... those are just space-based things => shouldn't they be considered as warnings ? (I tested it, it works perfectly)

Shankhanil commented 4 years ago

I shall take a look ASAP @unguest

EDIT: I took a look, and the errors that are occurring are linter errors thrown by ESLINT. We are using ESLINT so that all the code that is contributed maintain a standard coding format. All you need to do, is run eslint --fix ./src/* and then commit the changes to your unguest/adobe-brackets/encode-decode : master branch. I am sure they will be alright.

unguest commented 4 years ago

Oh ok thank you !

unguest commented 4 years ago

YOOHOOO => I've just undertand why it didn't works...

If you have any review / changes to submit me, I'm taking !

nadchif commented 4 years ago

Great job @unguest. Thank you once again.

unguest commented 4 years ago

No problem !

BTW, is there any encoder 'needed' or let's say more important to implement ?

nadchif commented 4 years ago

No problem !

BTW, is there any encoder 'needed' or let's say more important to implement ?

Yes, but we are still discussing and trying to work things out. Your input is welcome and valuable: https://ossenthusiasts.slack.com/archives/C01391X0B4K

unguest commented 4 years ago

Oh nice I'm joining !

unguest commented 4 years ago

@nadchif I need you to invite me to check the link you mention. Accoring you are using Slack, you may use the following email address : unguestdev@gmail.com