search

nadchif / html-duration-picker.js

Turn an HTML input box to a duration picker, without jQuery
https://nadchif.github.io/html-duration-picker.js/
Apache License 2.0
45 stars 62 forks source link

fix for angular issue. #164

Closed wyntonfranklin closed 1 year ago

wyntonfranklin commented 1 year ago

fix angular model values not updating

nadchif commented 1 year ago

Hi @wyntonfranklin thank you for the contribution to solving the angular issue. I've refactored a bit in order to still have intervalId = setInterval(changeValueByArrowKeys, 200, inputBox, 'down'/'up') working. It is used when users click and hold down the mouse on up or down buttons.

May please push the commits to this branch and please let me know if everything still works as expected in Angular

wyntonfranklin commented 1 year ago

Sure I'll check it out

wyntonfranklin commented 1 year ago

Hi @nadchif it works as expected. No issues in angular. I really didn't fully understand the interval usage.

nadchif commented 1 year ago

Thank you @wyntonfranklin. As there are now some issues with the unit tests, I commented out this part . I will also merge this to a dev branch and later investigate what's going on with the unit tests 🙂