naddison36 / sol2uml

Solidity contract visualisation tool
MIT License
1.12k stars 257 forks source link

Missing associations when emitting events #122

Closed naddison36 closed 1 year ago

naddison36 commented 1 year ago

An example is in this contract 0xC6845a5C768BF8D7681249f8927877Efda425baf on mainnet. The associations from the StableAndVariableTokensHelper and ATokensAndRatesHelper contracts to the StringLib library are missing.

The StableAndVariableTokensHelper.initDeployment function has the following expression.

emit deployedContracts(
  address(
    new StableDebtToken(
      pool,
      tokens[i],
      StringLib.concat('Aave stable debt bearing ', symbols[i]),
      StringLib.concat('stableDebt', symbols[i]),
      incentivesController
    )
  ),
  address(
    new VariableDebtToken(
      pool,
      tokens[i],
      StringLib.concat('Aave variable debt bearing ', symbols[i]),
      StringLib.concat('variableDebt', symbols[i]),
      incentivesController
    )
  )
);

The ATokensAndRatesHelper.initDeployment function has the following expression.

emit deployedContracts(
  address(
    new AToken(
      LendingPool(pool),
      assets[i],
      treasuryAddress,
      StringLib.concat('Aave interest bearing ', symbols[i]),
      StringLib.concat('a', symbols[i]),
      incentivesController
    )
  ),
  address(
    new DefaultReserveInterestRateStrategy(
      LendingPoolAddressesProvider(addressesProvider),
      rates[i][0],
      rates[i][1],
      rates[i][2],
      rates[i][3],
      rates[i][4],
      rates[i][5]
    )
  )
);
naddison36 commented 1 year ago

Fixed with v2.3.1