search

naddison36 / sol2uml

Solidity contract visualisation tool
MIT License
1.12k stars 257 forks source link

Strictly speaking, "< 1024" and "not larger than 1024" are not equivalent. #137

Closed mikel-misha closed 1 year ago

mikel-misha commented 1 year ago

Strictly speaking, "< 1024" and "not larger than 1024" are not equivalent.

1. Check that the <code>[=credentialId=]</code> is &le; 1023 bytes. Credential IDs larger than this many bytes SHOULD cause the RP to fail this [=registration ceremony=].

And if I may (this is more subjective), I think it's worth eliminating the little indirection here. Not that it's a lot of cognitive load, but every bit helps.

1. Check that the <code>[=credentialId=]</code> is &le; 1023 bytes long. Credential IDs larger than 1023 bytes SHOULD cause the RP to fail this [=registration ceremony=].

_Originally posted by @emlun in https://github.com/w3c/webauthn/pull/1664#discussion_r713335901_

naddison36 commented 1 year ago

more spam

mikel-misha commented 1 year ago

more spam