search

naddison36 / sol2uml

Solidity contract visualisation tool
MIT License
1.12k stars 257 forks source link

Large Png's are not fully written to the file sometimes. #148

Open startswithaj opened 1 year ago

startswithaj commented 1 year ago

Thanks for producing this @naddison36

When I generate a large diagram and output to a png. It seems like the whole image is not getting written to the file. Ends up with a partial image. It's intermittent, it doesn't always happen. Seems like it could be a race condition between the file being written and the program exiting. Maybe the file write isn't being awaited?

Screenshot 2023-05-04 at 4 05 36 pm
naddison36 commented 1 year ago

Thanks for reporting. Is there an example contract this sometimes happens for?

startswithaj commented 1 year ago

hey @naddison36 its a private repo that I'm working on. I can have a look for a public repo thats big and try and repro.

startswithaj commented 1 year ago

Had a quick look at the code that writes the file. Looks tight. It could be the fault of convert-svg-to-png