search

nadeemlab / SPT

Spatial profiling toolbox for spatial characterization of tumor immune microenvironment in multiplex images
https://oncopathtk.org
Other
21 stars 2 forks source link

allow starting only one ondemand service #203

Closed CarlinLiao closed 1 year ago

CarlinLiao commented 1 year ago

Pursuant to #202. All tests pass. This should be ready for @wooferclaw to build on.

jimmymathews commented 1 year ago

For this we will also need to update ondemand/service_client.py:

https://github.com/nadeemlab/SPT/blob/93a8be3dcaf389acda6108746a9138cbb117cd32/spatialprofilingtoolbox/ondemand/service_client.py#L156-L159

Some "service" parameter is needed that should trigger the client to look in a service-specific environment variable for the hostname.

Also the calls to OnDemandRequester should probably be rewritten to be service-specialized (in apiserver/app/main.py).

jimmymathews commented 1 year ago

I have tested this locally in minimal setup. The --service=... flag does seem to cause only the specified service to start up. And the OnDemandRequester client works with service='...'.

jimmymathews commented 1 year ago

There may still be some need to alter the ondemand image's Dockerfile to explicitly support specializable CMD command, but I'm not sure how that works yet.